introduce sync calls for systems not doing fsync#704
Merged
Conversation
Contributor
Author
|
@rschu1ze @alexey-milovidov any updates on this? |
george-larionov
approved these changes
Jan 30, 2026
george-larionov
left a comment
george-larionov
left a comment
Member
There was a problem hiding this comment.
LGTM, I'll merge this PR and then re-run the affected benchmarks on our end to double check. Thanks for contributing!
rschu1ze
reviewed
Feb 4, 2026
| # Measure load time including sync to disk | ||
| start=$(date +%s.%N) | ||
|
|
||
| clickhouse-client \ |
Member
There was a problem hiding this comment.
@george-larionov Should we simply add MT setting fsync_after_insert to the CREATE TABLE definition? This seems easier (fewer code changes) and more concise.
Member
|
I guess we should also update the non- |
Member
Ah, only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sync around data loading for ClickHouse and Ursa as their load times are below the theoretical minimum for instances where the whole dataset fits into memory (cf Issue #678) .
I would also have liked to done it for TCHouse-C and Clickhouse Cloud but I have no idea of how to do that there.
I'm also sure there are other systems that don't do syncs but have longer load times anyway - I currently don't have time to test them all, though.
Also measured that locally on CedarDB and DuckDB - didn't have any effect, as expected. If you want to, we can also include it in future commits, though!